Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1362#discussion_r143614990
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
    @@ -321,6 +315,11 @@ private static ColumnPage 
newLVBytesPage(TableSpec.ColumnSpec columnSpec,
       public abstract void setShortIntPage(byte[] shortIntData);
     
       /**
    +   * Set boolean values to page
    +   */
    +  public abstract void setBooleanPage(byte[] booleanData);
    --- End diff --
    
    Since internally boolean is stored as byte, so you can implement this 
function to call setBytePage instead of abstract function


---

Reply via email to