Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1672#discussion_r157339584
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -1394,20 +1394,20 @@ public static String printLine(String a, int num) {
* Below method will be used to get the list of segment in
* comma separated string format
*
- * @param segmentList
+ * @param strings
* @return comma separated segment string
*/
- public static String getSegmentString(List<String> segmentList) {
- if (segmentList.isEmpty()) {
+ public static String convertToString(List<String> strings) {
--- End diff --
please modify input param to a more readable name and update the comment
for this function
---
