Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1672#discussion_r157339661
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoCommand.scala
 ---
    @@ -40,7 +41,11 @@ case class CarbonInsertIntoCommand(
           scala.collection.immutable.Map("fileheader" -> header),
           overwrite,
           null,
    -      Some(df)).run(sparkSession)
    +      Some(df),
    --- End diff --
    
    please add the parameter name also, it is not easy to check the parameter. 
change to like:
    ```
       foo(
        paramA = a,
        paramB = b
        ...)
    ```


---

Reply via email to