Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1672#discussion_r157652168
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
 ---
    @@ -395,4 +391,14 @@ object CarbonFilters {
           case _ => expressions
         }
       }
    +
    +  def getPartitions(partitionFilters: Seq[Expression],
    +      sparkSession: SparkSession,
    +      identifier: TableIdentifier): Seq[String] = {
    +    val partitions =
    +      sparkSession.sessionState.catalog.listPartitionsByFilter(identifier, 
partitionFilters)
    +    partitions.toList.flatMap { f =>
    --- End diff --
    
    can you use case(xxx, xxx) to replace `f`, make it more readable


---

Reply via email to