[GitHub] carbondata pull request #1672: [CARBONDATA-1858][PARTITION] Support querying...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1672#discussion_r157652296
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonFilters.scala
 ---
    @@ -395,4 +391,14 @@ object CarbonFilters {
           case _ => expressions
         }
       }
    +
    +  def getPartitions(partitionFilters: Seq[Expression],
    --- End diff --
    
    I think it is better to do this logic in `pruneFilterProject` directly, 
this function is not needed


---