GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/carbondata/pull/1718
[CARBONDATA-1929][Validation]carbon property configuration validation
Added validation for below parameter:
carbon.timestamp.format
carbon.date.format
carbon.sort.file.write.buffer.size (minValue = 10 KB, maxValue=10MB,
defaultValue =16 KB )
carbon.sort.intermediate.files.limit (minValue = 2, maxValue=50,
defaultValue =20 )
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
NA
- [X] Any backward compatibility impacted?
NA
- [X] Document update required?
NA
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
Added test case for property validation.
- [X] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata
propValidation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1718
----
commit 7b484a8b3d9e8190fafaecbf04b771c7a758e293
Author: mohammadshahidkhan <mohdshahidkhan1987@...>
Date: 2017-12-22T11:22:44Z
[CARBONDATA-1929][Validation]carbon property configuration validation
----
---
