Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1718#discussion_r158671250
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
    @@ -107,36 +108,103 @@ private void validateAndLoadDefaultProperties() {
         validateCarbonCSVReadBufferSizeByte();
         validateHandoffSize();
         validateCombineSmallInputFiles();
    +    // The method validate the validity of configured 
carbon.timestamp.format value
    +    // and reset to default value if validation fail
    +    validateCarbonKey(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
    +        CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
    +    // The method validate the validity of configured carbon.date.format 
value
    +    // and reset to default value if validation fail
    +    validateCarbonKey(CarbonCommonConstants.CARBON_DATE_FORMAT,
    --- End diff --
    
    added validation check while addProperty also


---

Reply via email to