Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1584#discussion_r158614764
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -762,14 +762,12 @@ public static String 
checkAndAppendFileSystemURIScheme(String filePath) {
       }
     
       private static boolean checkIfPrefixExists(String path) {
    -    final String lowerPath = path.toLowerCase(Locale.getDefault());
    -    return lowerPath.startsWith(CarbonCommonConstants.HDFSURL_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.VIEWFSURL_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.LOCAL_FILE_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.ALLUXIOURL_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.S3N_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.S3_PREFIX) ||
    -        lowerPath.startsWith(CarbonCommonConstants.S3A_PREFIX);
    +    final String lowerPath = path.toLowerCase();
    +    return lowerPath.startsWith(CarbonCommonConstants.HDFSURL_PREFIX) || 
lowerPath
    --- End diff --
    
    better to move "lowerPath" to next row


---

Reply via email to