[GitHub] carbondata pull request #1584: [CARBONDATA-1827] Added S3 Implementation

[QiangCai]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1584#discussion_r158614229
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java 
---
    @@ -360,9 +361,10 @@ public static long getDirectorySize(String filePath) 
throws IOException {
           case ALLUXIO:
           case VIEWFS:
           case S3:
    -        Path path = new Path(filePath);
    -        FileSystem fs = path.getFileSystem(configuration);
    -        return fs.getContentSummary(path).getLength();
    +        Path s3Path = new Path(filePath);
    --- End diff --
    
    suggest moving S3 case into seperated block
    case HDFS:
    case ALLUXIO:
    case VIEWFS:
         ..... old  code
    case S3:
          .....new  code


---