Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1728#discussion_r159058055
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
@@ -1124,92 +1328,57 @@ case class
CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
*
* @param carbonTable
* parent table
- * @param aggFunctions
- * aggregation function
- * @param tableName
- * parent table name
+ * @param aggExp
+ * aggregate expression
* @return list of fields
*/
def validateAggregateFunctionAndGetFields(carbonTable: CarbonTable,
- aggFunctions: AggregateFunction,
- tableName: String
- ): Seq[QueryColumn] = {
+ aggExp: AggregateExpression): Seq[AggregateExpression] = {
val changedDataType = true
--- End diff --
Remove unused variable
---
