Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1728#discussion_r159058395
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
@@ -933,121 +1143,122 @@ case class
CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
* child data map schema
* @param attributes
* child logical relation
+ * @param expLogicalPlanToColumnSchemaMapping
+ * expression logical plan to data map column mapping
+ * @param parentTable
+ * parent carbon table
+ * @param logicalRelation
+ * logical relation
* @return updated expression
*/
def getUpdatedAggregateExpressionForChild(aggExp: AggregateExpression,
- dataMapSchema: DataMapSchema,
- attributes: Seq[AttributeReference]):
+ dataMapSchema: AggregationDataMapSchema,
+ attributes: Seq[AttributeReference],
+ expLogicalPlanToColumnSchemaMapping: Option[Map[LogicalPlan,
ColumnSchema]],
+ parentTable: CarbonTable,
+ logicalRelation: LogicalRelation):
Expression = {
+ val updatedAggExp = getUpdateAggregateExpressions(aggExp)
--- End diff --
Add code comment here
---
