Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1752#discussion_r159367321
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
 ---
    @@ -98,12 +96,25 @@ public CarbonOutputCommitter(Path outputPath, 
TaskAttemptContext context) throws
           new 
CarbonIndexFileMergeWriter().mergeCarbonIndexFilesOfSegment(segmentPath);
           String updateTime =
               
context.getConfiguration().get(CarbonTableOutputFormat.UPADTE_TIMESTAMP, null);
    +      String segmentsToBeDeleted =
    +          
context.getConfiguration().get(CarbonTableOutputFormat.SEGMENTS_TO_BE_DELETED, 
null);
           if (updateTime != null) {
             Set<String> segmentSet = new HashSet<>(
                 new 
SegmentStatusManager(carbonTable.getAbsoluteTableIdentifier())
                     .getValidAndInvalidSegments().getValidSegments());
    -        CarbonUpdateUtil.updateTableMetadataStatus(segmentSet, 
carbonTable, updateTime, true,
    -            new ArrayList<String>());
    +        List<String> segmentDeleteList;
    +        if (segmentsToBeDeleted != null)
    +        {
    --- End diff --
    
    move to previous line


---

Reply via email to