Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1752#discussion_r159594614
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala
---
@@ -58,14 +58,15 @@ object DeleteExecution {
dataRdd: RDD[Row],
timestamp: String,
isUpdateOperation: Boolean,
- executorErrors: ExecutionErrors): Boolean = {
+ executorErrors: ExecutionErrors): (Boolean, Seq[String]) = {
--- End diff --
It seems the first return value is always true
And it is hard to understand this function, can you add comment for it
---
