Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1879#discussion_r164944758
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNodeWrapper.java
 ---
    @@ -132,13 +132,48 @@ public DimensionRawColumnChunk 
getDimensionChunk(FileHolder fileReader, int bloc
       public MeasureRawColumnChunk[] getMeasureChunks(FileHolder fileReader, 
int[][] blockIndexes)
           throws IOException {
         MeasureColumnChunkReader measureColumnChunkReader = 
getMeasureColumnChunkReader();
    -    return measureColumnChunkReader.readRawMeasureChunks(fileReader, 
blockIndexes);
    +    MeasureRawColumnChunk[] measureRawColumnChunks =
    +        measureColumnChunkReader.readRawMeasureChunks(fileReader, 
blockIndexes);
    +    updateMeasureRawColumnChunkMinMaxValues(measureRawColumnChunks);
    +    return measureRawColumnChunks;
       }
     
       @Override public MeasureRawColumnChunk getMeasureChunk(FileHolder 
fileReader, int blockIndex)
           throws IOException {
         MeasureColumnChunkReader measureColumnChunkReader = 
getMeasureColumnChunkReader();
    -    return measureColumnChunkReader.readRawMeasureChunk(fileReader, 
blockIndex);
    +    MeasureRawColumnChunk measureRawColumnChunk =
    --- End diff --
    
    Does it require to change at runtime? is it possible to update those while 
calling `CarbonUtil.updateMinMaxValues`


---

Reply via email to