Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1879#discussion_r164953838
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataRefNodeWrapper.java
---
@@ -132,13 +132,48 @@ public DimensionRawColumnChunk
getDimensionChunk(FileHolder fileReader, int bloc
public MeasureRawColumnChunk[] getMeasureChunks(FileHolder fileReader,
int[][] blockIndexes)
throws IOException {
MeasureColumnChunkReader measureColumnChunkReader =
getMeasureColumnChunkReader();
- return measureColumnChunkReader.readRawMeasureChunks(fileReader,
blockIndexes);
+ MeasureRawColumnChunk[] measureRawColumnChunks =
+ measureColumnChunkReader.readRawMeasureChunks(fileReader,
blockIndexes);
+ updateMeasureRawColumnChunkMinMaxValues(measureRawColumnChunks);
+ return measureRawColumnChunks;
}
@Override public MeasureRawColumnChunk getMeasureChunk(FileHolder
fileReader, int blockIndex)
throws IOException {
MeasureColumnChunkReader measureColumnChunkReader =
getMeasureColumnChunkReader();
- return measureColumnChunkReader.readRawMeasureChunk(fileReader,
blockIndex);
+ MeasureRawColumnChunk measureRawColumnChunk =
--- End diff --
here I am not calling CarbonUtil.updateMinMaxValues. I am just reversing
the min and max values of measures based on oldStore flag. Thsi can be done
only during runtime because this min max is at the page level which is read
only at the the page level pruning
---
