Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1919#discussion_r165807745
  
    --- Diff: 
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/datamap/CarbonCreateDataMapCommand.scala
 ---
    @@ -60,7 +61,14 @@ case class CarbonCreateDataMapCommand(
         } else {
           dmProperties
         }
    -
    +    val dataMapProvider = {
    +      try {
    +        DataMapProvider.getDataMapProvider(dmClassName)
    --- End diff --
    
    suggest change "dmClassName" to "providerName"


---

Reply via email to