Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1919#discussion_r165809109
  
    --- Diff: format/src/main/thrift/schema.thrift ---
    @@ -192,13 +192,13 @@ struct DataMapSchema  {
         1: required string dataMapName;
         // class name
         2: required string className;
    +    // to maintain properties like select query, query type like groupby, 
join
    +    3: optional map<string, string> properties;
         // relation indentifier
    --- End diff --
    
    modify the comment also, give more information to let reader know it is the 
relation identifier for the preaggregate table used by `preaggregate` datamap. 
Not used by `timeseries` datamap, right?


---

Reply via email to