Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1972#discussion_r168677068
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
@@ -104,6 +104,38 @@ public static Object
getMeasureValueBasedOnDataType(String msrValue, DataType da
}
}
+ /**
+ * This method will convert a given value to its specific type
+ *
+ * @param msrValue
+ * @param dataType
+ * @param carbonMeasure
+ * @return
+ */
+ public static Object getConvertedMeasureValueBasedOnDataType(String
msrValue, DataType dataType,
--- End diff --
We have similar method getMeasureValueBasedOnDataType in the DataTypeUtil
class. Only difference in implementation is for decimal datatype. I think we
can refactor and put the common code in one private method
---
