[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1972#discussion_r169983220
  
    --- Diff: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java
 ---
    @@ -122,7 +119,11 @@ public CarbonOutputCommitter(Path outputPath, 
TaskAttemptContext context) throws
               throw new IOException(e);
             }
           }
    -      CarbonLoaderUtil.recordNewLoadMetadata(newMetaEntry, loadModel, 
false, overwriteSet);
    +      String uniqueId = null;
    +      if (overwriteSet) {
    +        uniqueId = overwritePartitions(loadModel);
    +      }
    +      CarbonLoaderUtil.recordNewLoadMetadata(newMetaEntry, loadModel, 
false, false);
    --- End diff --
    
    ok, changed


---