[GitHub] carbondata pull request #1982: [CARBONDATA-2184]Improve memory reuse for hea...

[jackylk]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1982#discussion_r169526789
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/memory/HeapMemoryAllocator.java 
---
    @@ -44,38 +44,49 @@ private boolean shouldPool(long size) {
       }
     
       @Override public MemoryBlock allocate(long size) throws OutOfMemoryError 
{
    -    if (shouldPool(size)) {
    +    int numWords = (int) ((size + 7) / 8);
    --- End diff --
    
    I think it is better to add a CarbonProperty to let user to enable this 
feature or not


---