Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1982#discussion_r170828032
--- Diff:
core/src/main/java/org/apache/carbondata/core/memory/HeapMemoryAllocator.java
---
@@ -23,59 +23,81 @@
import java.util.Map;
import javax.annotation.concurrent.GuardedBy;
+import org.apache.carbondata.core.util.CarbonProperties;
+
/**
* Code ported from Apache Spark {org.apache.spark.unsafe.memory} package
* A simple {@link MemoryAllocator} that can allocate up to 16GB using a
JVM long primitive array.
*/
public class HeapMemoryAllocator implements MemoryAllocator {
- @GuardedBy("this") private final Map<Long,
LinkedList<WeakReference<MemoryBlock>>>
+ @GuardedBy("this") private final Map<Long,
LinkedList<WeakReference<long[]>>>
bufferPoolsBySize = new HashMap<>();
- private static final int POOLING_THRESHOLD_BYTES = 1024 * 1024;
+ private int poolingThresholdBytes = 1024 * 1024;
--- End diff --
This assignment is not required
---
