Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1997#discussion_r170451389
  
    --- Diff: 
streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala
 ---
    @@ -67,7 +67,7 @@ object StreamSinkFactory {
           carbonLoadModel.getFactFilePath,
           false,
           parameters.asJava,
    -      null,
    +      parameters.asJava,
    --- End diff --
    
    add comment why we need to pass same parameters twice


---

Reply via email to