Github user sraghunandan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1997#discussion_r170451392
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonAppendableStreamSink.scala
 ---
    @@ -102,7 +102,7 @@ class CarbonAppendableStreamSink(
             carbonLoadModel.getFactFilePath,
             false,
             parameters.asJava,
    -        null,
    +        parameters.asJava,
    --- End diff --
    
    add comment why we need to pass same parameters twice


---

Reply via email to