Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2134#discussion_r180988394
--- Diff:
core/src/main/java/org/apache/carbondata/core/cache/dictionary/AbstractDictionaryCache.java
---
@@ -59,6 +59,10 @@ public AbstractDictionaryCache(CarbonLRUCache
carbonLRUCache) {
initThreadPoolSize();
}
+ @Override public void put(DictionaryColumnUniqueIdentifier key,
Dictionary value) {
--- End diff --
move @Override to previous line
please follow this in future
---