Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2134#discussion_r180988586
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/dev/CacheableDataMap.java 
---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datamap.dev;
    +
    +import java.io.IOException;
    +import java.util.List;
    +
    +import org.apache.carbondata.core.datamap.DataMapDistributable;
    +import org.apache.carbondata.core.memory.MemoryException;
    +
    +/**
    + * Interface for data map caching
    + */
    +public interface CacheableDataMap {
    --- End diff --
    
    I think BlockletDataMap is already cached, why this is needed


---

Reply via email to