Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2179#discussion_r182390285
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
@@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId) {
return new Segment(segmentId, null);
}
+ /**
+ * SegmentId can be combination of segmentNo and segmentFileName
--- End diff --
can you describe more what is in the SegmentId---
