[GitHub] carbondata pull request #2179: [CARBONDATA-2361] Refactoring ReadCommittedSt...

[sounakr]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2179#discussion_r183069772
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datamap/Segment.java ---
    @@ -80,6 +115,22 @@ public static Segment toSegment(String segmentId) {
         return new Segment(segmentId, null);
       }
     
    +  /**
    +   * SegmentId can be combination of segmentNo and segmentFileName
    +   * @param segmentId
    --- End diff --
    
    Done


---