Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2206#discussion_r183239230
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMapWriter.java ---
@@ -54,7 +54,7 @@ public DataMapWriter(AbsoluteTableIdentifier identifier,
Segment segment,
*
* @param blockId file name of the carbondata file
*/
- public abstract void onBlockStart(String blockId, long taskId) throws
IOException;
+ public abstract void onBlockStart(String blockId, String taskName)
throws IOException;
--- End diff --
All place in this PR which has `taskName` should be `indexShardName`, right?
---
