Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2206#discussion_r183271230
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java
---
@@ -102,24 +96,25 @@
this.indexedCarbonColumns = indexedCarbonColumns;
}
- private String getIndexPath(long taskId) {
+ private String getIndexPath(String taskName) {
if (isFineGrain) {
- return genDataMapStorePathOnTaskId(identifier.getTablePath(),
segmentId, dataMapName, taskId);
+ return genDataMapStorePathOnTaskId(identifier.getTablePath(),
segmentId, dataMapName,
+ taskName);
} else {
// TODO: where write data in coarse grain data map
- return genDataMapStorePathOnTaskId(identifier.getTablePath(),
segmentId, dataMapName, taskId);
+ return genDataMapStorePathOnTaskId(identifier.getTablePath(),
segmentId, dataMapName,
+ taskName);
}
}
/**
* Start of new block notification.
*/
- public void onBlockStart(String blockId, long taskId) throws IOException
{
+ public void onBlockStart(String blockId, String indexShardName) throws
IOException {
--- End diff --
In this method, we should only initialize indexWriter once.
It means all blocks of this task will share the index writer.
---
