Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2187#discussion_r184278866
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/DataRefNode.java ---
@@ -141,5 +141,5 @@ DimensionRawColumnChunk getDimensionChunk(FileHolder
fileReader, int blockIndexe
* @param pageNumber
* @return
*/
- int getPageRowCount(int pageNumber);
+ int getPageRowCount(int pageNumber) throws IOException;
--- End diff --
Avoid throwing IOException from this interface methods. Instead catch the
IO exception in the caller methods and wrap it in RuntimeException and throw
---