Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2187#discussion_r184280492
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/indexstore/UnsafeMemoryDMStore.java
 ---
    @@ -101,6 +102,7 @@ public void addIndexRow(DataMapRow indexRow) throws 
MemoryException {
       }
     
       private void addToUnsafe(CarbonRowSchema schema, DataMapRow row, int 
index) {
    +    schema.setDataType(DataTypeUtil.valueOf(schema.getDataType(), 0, 0));
    --- End diff --
    
    Remove this logic from here and add a method in AbstractMemoryDMStore 
called setSchemaDataType and set the datatypes at once in that method


---

Reply via email to