Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2257#discussion_r185400031
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
 ---
    @@ -244,10 +244,17 @@ public static CarbonTable buildFromDataFile(
         return buildFromTableInfo(tableInfo);
       }
     
    -  public static CarbonTable buildFromTablePath(
    -      String tableName, String tablePath) throws IOException {
    -    return SchemaReader.readCarbonTableFromStore(
    -        AbsoluteTableIdentifier.from(tablePath, tableName, "default"));
    +  public static CarbonTable buildFromTablePath(String tableName, String 
tablePath,
    +      boolean isTransactionalTable) throws IOException {
    --- End diff --
    
    I don't think it is required to pass `isTransactionalTable` to this mehod, 
handle inside `SchemaReader.readCarbonTableFromStore` if there is no schema 
exists then go for inferring.


---

Reply via email to