Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2257#discussion_r185402417
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -244,10 +244,17 @@ public static CarbonTable buildFromDataFile(
return buildFromTableInfo(tableInfo);
}
- public static CarbonTable buildFromTablePath(
- String tableName, String tablePath) throws IOException {
- return SchemaReader.readCarbonTableFromStore(
- AbsoluteTableIdentifier.from(tablePath, tableName, "default"));
+ public static CarbonTable buildFromTablePath(String tableName, String
tablePath,
+ boolean isTransactionalTable) throws IOException {
--- End diff --
From the reader perspective wanted to make a clear distinction if it is
reading a Transactional or Non Transactional table. So let's not infer in case
of transactional table. There may be some corruption due to which schema might
get deleted in transactional table but we are able to infer schema and move
forward, in this scenario user wont be able to know about the corruption
present.
---
