Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2254#discussion_r185431282
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
---
@@ -986,4 +990,26 @@ public boolean canAllow(CarbonTable carbonTable,
TableOperation operation) {
return true;
}
+ /**
+ * Get all index columns specified by dataMapSchema
+ */
+ public List<CarbonColumn> getIndexedColumns(DataMapSchema dataMapSchema)
--- End diff --
Because there are 15 usages of this function, and they all has
dataMapSchema. If I change to pass columnNames as input parameter, all 15
usages need to change and add more code, so I think it is better to keep in
this way, like a helper function
---
