Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2254#discussion_r185434808
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapRegistry.java ---
@@ -45,14 +51,40 @@
public class DataMapRegistry {
private static Map<String, String> shortNameToClassName = new
ConcurrentHashMap<>();
- public static void registerDataMap(String datamapClassName, String
shortName) {
+ private static void registerDataMap(String datamapClassName, String
shortName) {
Objects.requireNonNull(datamapClassName);
Objects.requireNonNull(shortName);
shortNameToClassName.put(shortName, datamapClassName);
}
- public static String getDataMapClassName(String shortName) {
+ private static String getDataMapClassName(String shortName) {
Objects.requireNonNull(shortName);
return shortNameToClassName.get(shortName);
}
+
+ public static DataMapFactory<? extends DataMap> getDataMapByShortName(
--- End diff --
ok, fixed
---
