Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2272#discussion_r186692843
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -154,12 +158,68 @@ public DataMapRefresher createRefresher(Segment
segment, String shardName) throw
@Override
public List<CoarseGrainDataMap> getDataMaps(DataMapDistributable
distributable)
throws IOException {
- return null;
+ List<CoarseGrainDataMap> coarseGrainDataMaps = new ArrayList<>();
+ BloomCoarseGrainDataMap bloomCoarseGrainDataMap = new
BloomCoarseGrainDataMap();
+ String indexPath = ((BloomDataMapDistributable)
distributable).getIndexPath();
+ try {
+ bloomCoarseGrainDataMap.init(new DataMapModel(indexPath));
+ } catch (IOException e) {
+ LOGGER.error(e, "Failed to get bloom datamap");
+ return coarseGrainDataMaps;
--- End diff --
why not throw e?
---
