Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2272#discussion_r186720877
--- Diff:
datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMapFactory.java
---
@@ -154,12 +158,65 @@ public DataMapRefresher createRefresher(Segment
segment, String shardName) throw
@Override
public List<CoarseGrainDataMap> getDataMaps(DataMapDistributable
distributable)
throws IOException {
- return null;
+ List<CoarseGrainDataMap> coarseGrainDataMaps = new ArrayList<>();
+ BloomCoarseGrainDataMap bloomCoarseGrainDataMap = new
BloomCoarseGrainDataMap();
+ String indexPath = ((BloomDataMapDistributable)
distributable).getIndexPath();
+ bloomCoarseGrainDataMap.init(new DataMapModel(indexPath));
+ coarseGrainDataMaps.add(bloomCoarseGrainDataMap);
+ return coarseGrainDataMaps;
+ }
+
+ /**
+ * returns all the directories of lucene index files for query
+ * Note: copied from luceneDataMapFactory, will extract to a common
interface
--- End diff --
Add a TODO
---
