Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2280#discussion_r186693004
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java 
---
    @@ -277,7 +275,7 @@ private static void addChildrenBlockIndex(Set<Integer> 
blockIndexes, CarbonDimen
        */
       public static Map<String, Dictionary> getDimensionDictionaryDetail(
           List<ProjectionDimension> queryDimensions, Set<CarbonDimension> 
filterComplexDimensions,
    -      AbsoluteTableIdentifier absoluteTableIdentifier, TableProvider 
tableProvider)
    +      AbsoluteTableIdentifier absoluteTableIdentifier, CarbonTable 
carbonTable)
    --- End diff --
    
    Do you need to keep both AbsoluteTableIdentifier and CarbonTable?


---

Reply via email to