Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2280#discussion_r186693055
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java 
---
    @@ -341,16 +339,15 @@ private static void 
getChildDimensionDictionaryDetail(CarbonDimension queryDimen
        * @throws IOException
        */
       private static Map<String, Dictionary> getDictionaryMap(List<String> 
dictionaryColumnIdList,
    -      AbsoluteTableIdentifier absoluteTableIdentifier, TableProvider 
tableProvider)
    +      AbsoluteTableIdentifier absoluteTableIdentifier, CarbonTable 
carbonTable)
    --- End diff --
    
    Do you need to keep both AbsoluteTableIdentifier and CarbonTable?


---

Reply via email to