Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2274#discussion_r186921945
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java 
---
    @@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws 
IOException, InvalidLoadOptionE
           // we are still using the traditional carbon table folder structure
           persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path));
         }
    -
    +    if (!table.isTransactionalTable()) {
    +      CarbonProperties.getInstance()
    +          .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false");
    --- End diff --
    
    This will impact others, why not let SDK user to set it


---

Reply via email to