Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2274#discussion_r187368858
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws
IOException, InvalidLoadOptionE
// we are still using the traditional carbon table folder structure
persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path));
}
-
+ if (!table.isTransactionalTable()) {
+ CarbonProperties.getInstance()
+ .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false");
--- End diff --
Intention was to prevent 'unsafe' property from being used by SDK user by
default. Otherwise they have to configure memory for unsafe also. So making it
simple to use.
Any way we will update the doc how SDK user can set the property by
following code:
CarbonProperties.getInstance() .addProperty("property", "value");
---
