Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187551083
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java ---
    @@ -331,6 +331,10 @@ public static Object getDataBasedOnDataType(String 
data, DataType actualDataType
           return ByteUtil.toBytes(Integer.parseInt(dimensionValue));
         } else if (actualDataType == DataTypes.LONG) {
           return ByteUtil.toBytes(Long.parseLong(dimensionValue));
    +    } else if (actualDataType == DataTypes.DOUBLE) {
    +      return 
ByteUtil.toBytes(Double.doubleToLongBits(Double.parseDouble(dimensionValue)));
    --- End diff --
    
    Add methods in ByteUtil to convert from double to byte array and byte array 
to double instead of handling here


---

Reply via email to