Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2297#discussion_r187555180
  
    --- Diff: 
integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
 ---
    @@ -393,13 +393,6 @@ class TableNewProcessor(cm: TableModel) {
         var allColumns: Seq[ColumnSchema] = Seq[ColumnSchema]()
         fieldChildren.foreach(fields => {
           fields.foreach(field => {
    -        if (!useDictionaryEncoding &&
    --- End diff --
    
    This was added to block double/date/decimal for complex type in case of 
dictionary exclude as now it is supported remove the same. this check is only 
applicable for complex type children


---

Reply via email to