Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2310#discussion_r188848603
--- Diff:
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
---
@@ -162,14 +162,16 @@ public DataMapBuilder createBuilder(Segment segment,
String shardName) {
* Get all distributable objects of a segmentid
*/
@Override
- public List<DataMapDistributable> toDistributable(Segment segment) {
+ public List<DataMapDistributable> toDistributable(Segment segment,
boolean isJobToClearDataMaps) {
--- End diff --
Don't change datamap interface, if the
`segment.getFilteredIndexShardNames()` is null then get all.
---
