Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2310#discussion_r188848658
  
    --- Diff: 
datamap/examples/src/minmaxdatamap/main/java/org/apache/carbondata/datamap/examples/MinMaxIndexDataMapFactory.java
 ---
    @@ -123,7 +123,8 @@ public DataMapBuilder createBuilder(Segment segment, 
String shardName)
        * @param segment
        * @return
        */
    -  @Override public List<DataMapDistributable> toDistributable(Segment 
segment) {
    +  @Override public List<DataMapDistributable> toDistributable(Segment 
segment,
    --- End diff --
    
    Don't change interface


---

Reply via email to