GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2325
[CARBONDATA-2499][Test] Validate the visible/invisible status of datamap
This jira https://issues.apache.org/jira/browse/CARBONDATA-2380 not check
the visible/invisible status of datamap. There will not thro exception when
the related code changed and affect visible/invisible status of datamap. So we
should add some test case for this function.
When I develop https://github.com/apache/carbondata/pull/2290, carbon don't
throw exception when I change the
org.apache.carbondata.core.datamap.DataMapStoreManager#getAllVisibleDataMap
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance
test report.
- Any additional information to help reviewers in testing this
change.
add some test cases
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xubo245/carbondata
CARBONDATA-2499-validateVisible
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2325.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2325
----
commit a42afea3c1d55bde4b07fa7dbb972262e45be100
Author: xubo245 <xubo29@...>
Date: 2018-05-21T07:47:24Z
[CARBONDATA-2499][Test] Validate the visible/invisible status of datamap
----
---
