Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2325#discussion_r189808113
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/datamap/FGDataMapTestCase.scala
---
@@ -481,6 +479,62 @@ class FGDataMapTestCase extends QueryTest with
BeforeAndAfterAll {
sql("select * from normal_test where name='n502670' and
city='c2670'"))
}
+ test("test fg datamap and validate the visible and invisible status of
datamap ") {
--- End diff --
I think you can add a new testcaseSuite to test the visibility of datamap
and it will eliminate some duplicate code.
Besides, I've noticed that you pointed that the invisibility for lucence
datamap may cause failure. Better to add that test in the same testcaseSuite.
---
