Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2338#discussion_r191094718
  
    --- Diff: 
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java ---
    @@ -409,4 +409,76 @@ public boolean accept(File pathname) {
             badRecordLoc);
       }
     
    +  @Test
    +  public void testReadFilesWithProjectAllColumns() throws IOException, 
InterruptedException {
    +    String path = "./testWriteFiles";
    +    FileUtils.deleteDirectory(new File(path));
    +
    +    Field[] fields = new Field[2];
    +    fields[0] = new Field("name", DataTypes.STRING);
    +    fields[1] = new Field("age", DataTypes.INT);
    +
    +    TestUtil.writeFilesAndVerify(new Schema(fields), path, true);
    +
    +    CarbonReader reader = CarbonReader
    +        .builder(path, "_temp")
    +        .projectAllColumns()
    --- End diff --
    
    Please add a test case pass null string to projection API. for e.g.
    .projection(new String[]{})


---

Reply via email to