Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2338#discussion_r191094883
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
---
@@ -152,9 +179,10 @@ public CarbonReaderBuilder setEndPoint(String value) {
if (filterExpression != null) {
format.setFilterPredicates(job.getConfiguration(), filterExpression);
}
- if (projectionColumns != null) {
- format.setColumnProjection(job.getConfiguration(), new
CarbonProjection(projectionColumns));
+ if (projectionColumns == null) {
--- End diff --
Rather than checking projectionColumns better to set a member variable like
projectAllColumns when projectAllColumns() API is being used. Only incase
projectAllColumns is show all columns. projectionColumns can be null in many
other cases also.
---
