Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2252#discussion_r194350793
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java
 ---
    @@ -30,21 +30,19 @@
     
       /**
        * Constructor for this class
    -   * @param dataChunks
    -   * @param invertedIndex
    -   * @param invertedIndexReverse
    -   * @param numberOfRows
        */
       public VariableLengthDimensionColumnPage(byte[] dataChunks, int[] 
invertedIndex,
    -      int[] invertedIndexReverse, int numberOfRows) {
    +      int[] invertedIndexReverse, int numberOfRows, boolean 
isVarcharEncoded) {
    --- End diff --
    
    Its better to pass store type it self from the caller instead for boolean 


---

Reply via email to